fix: rollback isValid() in retrieveSchema() to validateFormData()#4418
Closed
cewald wants to merge 6 commits into
Closed
fix: rollback isValid() in retrieveSchema() to validateFormData()#4418cewald wants to merge 6 commits into
isValid() in retrieveSchema() to validateFormData()#4418cewald wants to merge 6 commits into
Conversation
…retrieveSchema() (rjsf-team#3575)" This reverts commit ff46301.
4 tasks
Member
heath-freenome
left a comment
heath-freenome
left a comment
There was a problem hiding this comment.
Looks good. One question and a small change to the CHANGELOG.md and you are good to go
Member
|
@cewald It looks like something in the utils tests are breaking. Can you please take a look... Also there are a few questions/concerns to address |
Author
|
I did not had time for checking the tests yet – but I actually "just reverted the changes". So there might be changes in the meantime that rely on the new version of code. Idk. I dont think I find time to debug those tests anytime soon, as I am not that much into the code and would need some time for research. |
Member
|
Closing in favor of #4723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #4357
This reverts commit ff46301
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.